Closed
Conversation
rhyslbw
force-pushed
the
test/network-agnostic-tests
branch
from
df2aa88 to
42144ce
Compare
rhyslbw
suggested changes
Feb 13, 2023
Contributor
rhyslbw
left a comment
rhyslbw
left a comment
There was a problem hiding this comment.
Looks good @iadmytro. It would be best to hoist getTestData to avoid defining the same function in each file. Also, these tests shouldn't be run with cardano-db-sync running, otherwise there are race conditions between querying for test data and then calling the API.
iadmytro
force-pushed
the
test/network-agnostic-tests
branch
from
42144ce to
b8bd71d
Compare
Contributor
Author
|
Hoisting of |
iadmytro
force-pushed
the
test/network-agnostic-tests
branch
from
b8bd71d to
f73e66c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Having dependency on particular testnet making regression suite very fragile and require substantial amount of work to switch to another testnet
Proposed Solution
Make regression suite network agnostic by querying db for suitable data for each test.
Important Changes Introduced
Network agnostic tests is a tradeoff, asserts performed by these tests not so rigorous as matching hardcoded snapshot.